^thehatsrule^

Group: Members
Posts: 3275
Joined: July 2006 |
 |
Posted: May 03 2008,06:42 |
 |
Quote (Jason W @ May 03 2008,00:58) | Ok, here is pretty much what i plan to include in the menu - a setup and a remove setup entry. |
Some comments after a glance at the code:
- are you sure you want to only look at the first line? What if other extensions want to do something similar, etc.? - the grep line may work, but it's actually checking wildcards. You'd need to escape it, or use -F, etc. and use anchors. A better way may be to use test (i.e. if [ `command` = "this" ]; then ) while (maybe) saving on some trivial resources
|